Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema validation does not support labels #260

Closed
nehanene15 opened this issue Jun 17, 2021 · 1 comment
Closed

Schema validation does not support labels #260

nehanene15 opened this issue Jun 17, 2021 · 1 comment
Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.

Comments

@nehanene15
Copy link
Collaborator

nehanene15 commented Jun 17, 2021 •
edited
Loading

Schema validation should support labels for consistency across validation types.

Schema validation outputs 'Pass'/'Fail' for the 'status' column in the result set. The other validation types output 'success'/'fail'.
@nehanene15 nehanene15 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 High priority. Fix may be included in the next release. labels Jun 17, 2021
@nehanene15 nehanene15 changed the title Schema validation 'status' result is not consistent with other validation types Schema validation does not support labels Jun 17, 2021
@nehanene15 nehanene15 added the Release Next release candidate label Jul 15, 2021
@nehanene15 nehanene15 added type: feature request 'Nice-to-have' improvement, new feature or different behavior or design. priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 High priority. Fix may be included in the next release. labels Aug 19, 2021
@nehanene15 nehanene15 removed the Release Next release candidate label Jan 6, 2022
@ajwelch4 ajwelch4 mentioned this issue Feb 26, 2022
Closed
@ajwelch4
Copy link
Member

Adding support for labels to schema validations should be easy once #371 and #379 are addressed.

ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Feb 27, 2022
@ajwelch4
fix: GoogleCloudPlatform#260
5873de9
ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Feb 27, 2022
@ajwelch4
fix: support labels for schema validation (GoogleCloudPlatform#260)
c0424f0
@ajwelch4 ajwelch4 mentioned this issue Feb 27, 2022
Merged
nehanene15 pushed a commit that referenced this issue Apr 6, 2022
@ajwelch4
fix: support labels for schema validation (#260) (#381)
f787701
@release-please release-please bot mentioned this issue Apr 6, 2022
Merged
nehanene15 added a commit that referenced this issue Apr 7, 2022
@nehanene15
Revert "fix: support labels for schema validation (#260) (#381)"
d0ebaeb 
This reverts commit f787701.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nehanene15 @ajwelch4