Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status shows 'success' when pct_difference in nan #341

Closed
nehanene15 opened this issue Nov 4, 2021 · 0 comments
Closed

Status shows 'success' when pct_difference in nan #341

nehanene15 opened this issue Nov 4, 2021 · 0 comments
Assignees
@wanting4
Labels
priority: p1 High priority. Fix may be included in the next release. Release Next release candidate type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nehanene15
Copy link
Collaborator

image

In line 129 in combiner.py there should be a check to ensure that the pct_difference isn't null before the status is calculated.
@nehanene15 nehanene15 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 High priority. Fix may be included in the next release. Release Next release candidate labels Nov 4, 2021
@nehanene15 nehanene15 mentioned this issue Nov 9, 2021
Closed
@wanting4 wanting4 self-assigned this Dec 16, 2021
ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Feb 15, 2022
@ajwelch4
fix: test for nan when calculating fail/success in combiner (GoogleCl…
6252bec 
…oudPlatform#341)
@ajwelch4 ajwelch4 mentioned this issue Feb 15, 2022
Merged
nehanene15 pushed a commit that referenced this issue Feb 18, 2022
@ajwelch4
fix: test for nan when calculating fail/success in combiner (#341) (#366
a9720c2 
)
@release-please release-please bot mentioned this issue Feb 18, 2022
Merged
ngdav pushed a commit that referenced this issue Mar 16, 2022
@ajwelch4 @ngdav
fix: test for nan when calculating fail/success in combiner (#341) (#366
796c618 
)
ngdav added a commit that referenced this issue May 4, 2022
@wanting4 @ngdav
@bluPhy @ajwelch4 @ajw0100 @nehanene15 @dmedora @renzokuken @dhercher
feat: Issue356 db2 test (#383)
70fb7bc 
* feat: add db2 connection

* feat: add connection

* feat: DB2 connection fix

* fix: do not require db2 client unless needed

* fix: Db2 count validation/agg functions, DB2Client

fixes sum, min, avg, max functions for mysql, ps, db2, and more
streamline DB2Client imports

* style: linting

* Fix: Multiple updates (#359)

* fix: update spelling

* fix:Adding double quote to prevent globbing and word splitting.

Adding double quote to prevent globbing and word splitting.

* fix:updating comment

* fix: Updating inline comments

* fix:Spelling

* fix:Updating spelling

* test: Support local integration tests for Teradata, Postgres and SQL Server (#364)

* test: get Teradata user name from TERADATA_USER env var

* test: add --no-cloud-sql flag to pytest options

* test: instantiate CloudSQLResourceManager in a fixture when --no-cloud-sql is not passed

* test: optionally get Postgres host from POSTGRES_HOST env var

* test: optionally get SQL Server host from SQL_SERVER_HOST env var

* test: optionally get SQL server user from SQL_SERVER_USER env var

Co-authored-by: A.J. Welch <[email protected]>

* fix: supporting non default schemas for mssql (#365)

* fix: supporting non default schemas for mssql

* fix:updated MSSQL client instantiation

* fix: typo

* feat: GCS support for validation configs (#340)

* gcs support for validation configs, incl. get and list functionality, and new 'configs' cmd

* fix: test for nan when calculating fail/success in combiner (#341) (#366)

* fix: ensure all statuses are success or fail, particularly after _join_pivots (#329) (#370)

* feat: first class support for row level hashing (#345)

* adding scaffolding for calc field builder in config manager

* exposing cast via calculated fields. Don't know if we necessarily need this just adding for consistency

* diff check

* config file generating as expected

* expanding cli for row level validations

* splitting out comparison fields from aggregates

* row comparisons operational (sort of)

* re-enabling aggregate validations

* cohabitation of validation types!

* figuring out why unit tests are borked

* continuing field split

* stash before merge

* testing diff

* tests passing

* removing extra print statements

* tests and lint

* adding fail tests

* first round of requested changes

* change requests round two.

* refactor CLI and lint

* swapping out farm fingerprint for sha256 as default

* changes per CR

* fixing text result tests

* adding docs

* hash example

* linting

* think I found the broken test

* fixed tests

* setting default for depth length

* relaxing system test

* feat: Hive partitioned tables support (#375)

* feat: add support for partitioned tables

* feat: import schema class

* fix: update docs

* fix: use an appropriate column filter list for schema validation (#350) (#371)

* fix: make status values consistent across validation types (#377) (#378)

* fix: make status values consistent across validation types (#377)

* fix: make validation status values consts (#377)

* fix: revert change from #345 that causes filters, threshold and labels to be ignored for column validations (#376) (#379)

* feat: Hive hash function support (#392)

* adding addons for impala hive hashing functions

* fix: import fixed_arity

* move logic to ibis_addon

* replacing isnull with nvl

* adding nvl function

* test FillNa

* missing import

* updating t0 prefix to column names



Co-authored-by: Mike Hilton <[email protected]>

* docs: add Db2 link to README

Co-authored-by: Elaina Yao <[email protected]>
Co-authored-by: David Ng <[email protected]>
Co-authored-by: Alejandro Leal <[email protected]>
Co-authored-by: AJ <[email protected]>
Co-authored-by: A.J. Welch <[email protected]>
Co-authored-by: Neha Nene <[email protected]>
Co-authored-by: dmedora <[email protected]>
Co-authored-by: Mike Hilton <[email protected]>
Co-authored-by: ngdav <[email protected]>
Co-authored-by: Dylan Hercher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanting4 wanting4

Labels
priority: p1 High priority. Fix may be included in the next release. Release Next release candidate type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nehanene15 @wanting4