Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Validation of Schema only support Teradata and CloudSpanner #355

Closed
chenjienn opened this issue Dec 28, 2021 · 0 comments
Closed

Is Validation of Schema only support Teradata and CloudSpanner #355

chenjienn opened this issue Dec 28, 2021 · 0 comments
Labels
priority: p1 High priority. Fix may be included in the next release. Release Next release candidate type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chenjienn
Copy link

chenjienn commented Dec 28, 2021 •
edited
Loading

when I want to use the command data-validation validate schema between postgresql and oracle, it throw below exception

  File "/Users/jiechen/miniconda3/envs/py37/lib/python3.7/site-packages/data_validation/schema_validation.py", line 36, in execute  
    ibis_source_schema = self.config_manager.source_client.get_schema(  
AttributeError: 'OracleClient' object has no attribute 'get_schema'

so when I trace the other database Client Class, I found only teradata and cloudspanner has the api get_schema
@chenjienn chenjienn changed the title Is Validation of Schema only support Teradata and CloudSpanner? Is Validation of Schema only support Teradata and CloudSpanner Dec 29, 2021
@nehanene15 nehanene15 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 High priority. Fix may be included in the next release. Release Next release candidate labels Jan 6, 2022
ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Feb 27, 2022
@ajwelch4
fix: support schema validation for other clients (GoogleCloudPlatform…
8bbc151 
…#355)
ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Feb 27, 2022
@ajwelch4
fix: support schema validation for more clients (GoogleCloudPlatform#355
1b0a521 
)
@ajwelch4 ajwelch4 mentioned this issue Feb 27, 2022
Merged
ajwelch4 added a commit to ajwelch4/professional-services-data-validator that referenced this issue Mar 2, 2022
@ajwelch4
fix: support schema validation for more clients (GoogleCloudPlatform#355
4517300 
)
nehanene15 pushed a commit that referenced this issue Mar 16, 2022
@ajwelch4
fix: support schema validation for more clients (#355) (#380)
ed46295 
* fix: support schema validation for more clients (#355)

* fix: use consts.VALIDATION_STATUS_SUCCESS
@release-please release-please bot mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 High priority. Fix may be included in the next release. Release Next release candidate type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenjienn @nehanene15