Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema validation: Teradata NUMBER is read as float64 instead of decimal #838

Closed
nj1973 opened this issue May 11, 2023 · 0 comments · Fixed by #874
Closed

schema validation: Teradata NUMBER is read as float64 instead of decimal #838

nj1973 opened this issue May 11, 2023 · 0 comments · Fixed by #874
Assignees

Comments

@nj1973
Copy link
Contributor

nj1973 commented May 11, 2023

Example columns:

,   col_dec_20      NUMBER(20)
,   col_dec_38      NUMBER(38)
,   col_dec_10_2    NUMBER(10,2)

DVT schema validation is reading these as float64. They should be decimal(20), decimal(38) and decimal(10,2).

When this is fixed we need to update integration test in test_teradata.py to use the correct types in allow list, search for "issue-838" in the file.

We also see column validation for Teradata NUMBER to BigQuery NUMERIC validations fail with:

TypeError: unsupported operand type(s) for -: 'decimal.Decimal' and 'float'

I suspect this will also be fixed by the same action as schema validation. Again search for "issue-838" in test_teradata.py to enable column validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants