Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle numeric datatype mapping in teradata schema and fix int mapping as per teradata doc #874

Merged
merged 3 commits into from
May 31, 2023
Merged

fix: handle numeric datatype mapping in teradata schema and fix int mapping as per teradata doc #874

merged 3 commits into from
May 31, 2023

Conversation

sharangagarwal
Copy link
Contributor

Closes #838

  • Change return function of def to_ibis_from_D in datatypes.py to dt.Decimal(precision, scale) from float64
  • Align datatype codes of int, smallint, byteint, bigint to official documentation of teradata
  • modified test_teradata.py to enable column validations

@sharangagarwal sharangagarwal requested a review from a team as a code owner May 30, 2023 09:35
@sharangagarwal sharangagarwal linked an issue May 30, 2023 that may be closed by this pull request
schema validation: Teradata NUMBER is read as float64 instead of decimal #838
Closed
@sharangagarwal
Copy link
Contributor Author

/gcbrun

@sharangagarwal
Copy link
Contributor Author

/gcbrun

@sharangagarwal sharangagarwal enabled auto-merge (squash) May 30, 2023 12:01
@sharangagarwal
Copy link
Contributor Author

/gcbrun

@sharangagarwal sharangagarwal merged commit 333eadb into develop May 31, 2023
@sharangagarwal sharangagarwal deleted the issue838 branch May 31, 2023 16:51
@release-please release-please bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raniksingh Raniksingh Raniksingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema validation: Teradata NUMBER is read as float64 instead of decimal
2 participants
@sharangagarwal @Raniksingh