feat: Support query parameter for MSSQL connection #1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1025
This supports user-provided query parameter for the MSSQL connection URL:
data-validation connections add -c mssqltest MSSQL --host 127.0.0.1 --port 1433 --user sqlserver --password passwrod --database guestbook --query '{"driver": "ODBC Driver 17 for SQL Server", "TrustServerCertificate": "yes", "authentication": "ActiveDirectoryIntegrated"}'
This also supports a user-provided connection URL:
data-validation connections add -c mssqltest MSSQL --url "mssql+pyodbc://user:[email protected]:1433/database?driver=ODBC+Driver+18+for+SQL+Server&TrustServerCertificate=yes&authentication=ActiveDirectoryIntegrated"