Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust find-tables to properly get Oracle and Postgres schemas #1034

Merged
merged 4 commits into from
Nov 11, 2023
Merged

fix: Adjust find-tables to properly get Oracle and Postgres schemas #1034

merged 4 commits into from
Nov 11, 2023

Conversation

helensilva14
Copy link
Contributor

Closes #1017

@helensilva14 helensilva14 linked an issue Nov 7, 2023 that may be closed by this pull request
find-tables not working #1017
Closed
@helensilva14 helensilva14 changed the title fix: Adjust find-tables to get Oracle schema as source fix: Adjust find-tables to properly get Oracle and Postgres schemas Nov 10, 2023
@helensilva14 helensilva14 changed the title fix: Adjust find-tables to properly get Oracle and Postgres schemas fix: Adjust find-tables to properly get Oracle and Postgres schemas Nov 10, 2023
@helensilva14
Copy link
Contributor Author

/gcbrun

@helensilva14 helensilva14 marked this pull request as ready for review November 10, 2023 20:29
@helensilva14 helensilva14 requested a review from a team as a code owner November 10, 2023 20:29
nj1973
nj1973 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@nj1973 nj1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, only comment is that we don't have any tests for find-tables to protect against regressions.

I'll leave it up to you, seeing as this is a customer issue you could merge this and add a new issue to create some tests at some in the future if you prefer.

@helensilva14 helensilva14 mentioned this pull request Nov 11, 2023
Open
@helensilva14
Copy link
Contributor Author

@nj1973 Thank you, totally agree! I tried to create a test for it to check how much effort it'd require and I couldn't make it work for now even with some searching. Regardless, I created #1043 and added my initial attempts there!

@helensilva14 helensilva14 merged commit 45fb40a into develop Nov 11, 2023
5 checks passed
@helensilva14 helensilva14 deleted the issue1017-find-tables-not-working branch November 11, 2023 23:25
@release-please release-please bot mentioned this pull request Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nj1973 nj1973 nj1973 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

find-tables not working
2 participants
@helensilva14 @nj1973