fix: Spanner generate-partition to use BQ dialect #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
sundar-mudupalli-work
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Neha,
Thanks. This looks good to me. I could not track down the source of to_sql myself. You can find the backend from the ibis table expression, there is a method called _find_backend(). The dry run code could use ibis.to_sql(query) instead of checking if the backend is SQLAlchemy or a SQL backend and doing different actions. Some ideas after a lot of code exploration.
Sundar Mudupalli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1059
The ibis.to_sql() method (code here) defaults the sqlglot_dialect as
backend.nameunless passed in as a parameter. Since Spanner isn't supported by sqlglot, this PR passes in BigQuery as the dialect since they have interchangeable SQL syntax.