feat: Add support to generate a JSON config file only for applications purposes #1089
Conversation
https://github.com/GoogleCloudPlatform/professional-services-data-validator into issue901-json-config-schema-validation-excluding-cols
helensilva14
force-pushed
the
issue901-json-config-schema-validation-excluding-cols
branch
from
b62867a
to
e4e2f4a
Compare
helensilva14
force-pushed
the
issue901-json-config-schema-validation-excluding-cols
branch
from
e4e2f4a
to
0d43de9
Compare
|
|
||
| Our Cloud Run sample also expects a raw JSON config in the `'data'` variable shown | ||
| [here](https://github.com/GoogleCloudPlatform/professional-services-data-validator/tree/develop/samples/run#test-cloud-run-endpoint). | ||
| You can get the JSON content specific for your scenario by using our CLI and providing the argument to generate the JSON config file [`--config-file-json` or `-cj <filepath>.json`]. IMPORTANT: do not forget to make the necessary adjustments between JSON and Python objects, check [this link as a reference](https://python-course.eu/applications-python/json-and-python.php). |
There was a problem hiding this comment.
Does Cloud Run/Airflow require the JSON to be converted to a Python object? I think the request is expected to be JSON... in that case we can remove the disclaimer.
There was a problem hiding this comment.
They don't necessarily require the conversion, but in both of our samples (Cloud Run, Airflow) we're directly initializing/stating the JSON content inside the Python code as a Dict object. So in these cases is necessary to perform the data types adjustments, but the user can always provide the pure JSON if they want to by using the json.loads() method or something similar.
Yes, they were not being used at all and the directory name was quite misleading, as if it had sample code to create test methods using DVT or something like that. |
helensilva14
deleted the
issue901-json-config-schema-validation-excluding-cols
branch
Fixes #908
New optional CLI flag parameter for any type of validation:
[--config-file-json or -cj CONFIG_FILE_JSON]JSON Config File Path to be used for storing validations for application purposes, since we only support generating a JSON config file and all other features are exclusive for YAML config files.
/gcbrun