Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for cx_Oracle's DB_TYPE_LONG_RAW #1095

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

helensilva14
Copy link
Contributor

Copy link

conventional-commit-lint-gcf bot commented Feb 14, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@helensilva14 helensilva14 added the automerge Summon MOG for automerging label Feb 14, 2024
@helensilva14 helensilva14 marked this pull request as ready for review February 14, 2024 22:44
@helensilva14 helensilva14 requested a review from a team as a code owner February 14, 2024 22:44
@nj1973
Copy link
Contributor

nj1973 commented Feb 15, 2024

I don't think adding LONG RAW to _type_mapping is enough on its own.
I suspect we also need to register the type like we do for other data types, however this is not simple because SQL Alchemy doesn't appear to have LONG RAW support either.

@nj1973
Copy link
Contributor

nj1973 commented Feb 15, 2024

/gcbrun

@nj1973
Copy link
Contributor

nj1973 commented Feb 15, 2024

The changes in this PR prevent an exception being throw when validating a table that has a LONG RAW column, they do not add functionality to validate the data in LONG RAW columns. That would be a different issue. I don't think row validation is possible on Oracle LONG [RAW] data. We might be able to make column validation work but, like I said, I think that should be a new issue.

Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nj1973 nj1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@helensilva14 helensilva14 merged commit 90547ef into develop Feb 20, 2024
5 checks passed
@helensilva14 helensilva14 deleted the issue1904-oracle-dbtype-longraw-not-supported branch February 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Summon MOG for automerging size/M
Projects
None yet
3 participants