-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add support for cx_Oracle's DB_TYPE_LONG_RAW #1095
fix: Add support for cx_Oracle's DB_TYPE_LONG_RAW #1095
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
I don't think adding LONG RAW to |
/gcbrun |
The changes in this PR prevent an exception being throw when validating a table that has a LONG RAW column, they do not add functionality to validate the data in LONG RAW columns. That would be a different issue. I don't think row validation is possible on Oracle LONG [RAW] data. We might be able to make column validation work but, like I said, I think that should be a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
Closes #1094
Reference: https://cx-oracle.readthedocs.io/en/latest/api_manual/module.html#cx_Oracle.DB_TYPE_NCHAR
/gcbrun