Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Distributed DVT Cloud Run Jobs sample #1133

Merged
merged 6 commits into from
May 20, 2024
Merged

Conversation

nehanene15
Copy link
Collaborator

Sample code to run DVT in a distributed manner using Cloud Run and documentation clean up.

@nehanene15 nehanene15 requested a review from a team as a code owner May 14, 2024 19:15
@nehanene15
Copy link
Collaborator Author

nehanene15 commented May 14, 2024

/gcbrun

Copy link
Contributor

@nj1973 nj1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, LGTM otherwise.

README.md Outdated Show resolved Hide resolved
docs/internal/distributed_jobs.md Outdated Show resolved Hide resolved
docs/internal/distributed_jobs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nj1973 nj1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nehanene15 nehanene15 merged commit f51f327 into develop May 20, 2024
5 checks passed
@nehanene15 nehanene15 deleted the cloudrun-sample branch May 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants