fix: Update to support up to 10K partitions #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
1 similar comment
|
/gcbrun |
nehanene15
reviewed
May 20, 2024
sundar-mudupalli-work
changed the title
|
/gcbrun |
nehanene15
reviewed
May 21, 2024
Co-authored-by: Neha Nene <[email protected]>
Co-authored-by: Neha Nene <[email protected]>
Co-authored-by: Neha Nene <[email protected]>
|
/gcbrun |
…b.com/GoogleCloudPlatform/professional-services-data-validator into issue-1137-increase-max-partition-10k
|
/gcbrun |
nehanene15
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Per comment, I have updated the code to support 10K partitions. Supporting more than 10K partitions is a bit more complex as explained in that comment. It turned out to be a bit more complex than mentioned in the doc because the error message with
choiceslists all the choices as stated here, so I have used the suggested approach for large number of values.I suggest moving this to develop after review if it passes out integration tests. I have tested the code in my environment and it successfully produces 10K files and the first many work with
data-validation configs run -cdir. So no issues there.Thanks.
Sundar Mudupalli