Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support PKs with different casing for generate-partitions #1142

Merged
merged 3 commits into from
May 24, 2024
Merged

fix: Support PKs with different casing for generate-partitions #1142

merged 3 commits into from
May 24, 2024

Conversation

nehanene15
Copy link
Collaborator

Closes #1136

Instead of getting the PKs from args (--primary-keys column_a,columb_b), gets PKs from the ConfigManager which accounts for different casing between source and target systems.

@nehanene15 nehanene15 requested a review from a team as a code owner May 23, 2024 15:44
@nehanene15
Copy link
Collaborator Author

nehanene15 commented May 23, 2024 •
edited

/gcbrun

sundar-mudupalli-work
sundar-mudupalli-work approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sundar-mudupalli-work sundar-mudupalli-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neha,

Nice work. I like that the code changes look so simple. I also tested against the table def / sample data I had from FMCC - and it works both with upper case and lower case column names.

Great work.

Sundar Mudupalli

@nehanene15 nehanene15 merged commit 021ce75 into develop May 24, 2024
5 checks passed
@nehanene15 nehanene15 deleted the issue1136-partitions-case branch May 24, 2024 14:19
@release-please release-please bot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmedora dmedora dmedora approved these changes

@sundar-mudupalli-work sundar-mudupalli-work sundar-mudupalli-work approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate-table-partitions between Teradata and BQ does not work with uppercase primary key names
3 participants
@nehanene15 @dmedora @sundar-mudupalli-work