-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove JSON arguments in CLI #247
Conversation
I'm worried about this change, particularly to the tables. It removes the flexibility to select non-matching schemas on source and target. I personally use that feature quite often. I'm worried about this being a breaking change, perhaps it doesn't need to be? |
Updated the PR to use the '=' operator mapping for tables. A table can be provided like so: |
"--count", | ||
'["tripduration","start_station_name"]', | ||
"tripduration,start_station_name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets leave this one as JSON formatting to test backwards compat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
Removes JSON arguments in CLI. This fix is backwards compatible for JSON inputs if needed.
Includes README and docs/examples updates.
--tbls
flag to accept tables in the form schema:table:target_table--bq-result-handler
which accepts project_id.dataset.table for result output--rc
flag is still supported. I created a separate flag for BigQuery so we can add new result handlers in the future with their own configuration parameters (in case they require more inputs than project_id and table_id).--filters
flag to accept string valuesCloses #241