Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add secrets logic to ci #273

Merged
merged 1 commit into from
Jun 28, 2021
Merged

docs: add secrets logic to ci #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

## Untagged

### [1.3.1](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/compare/v1.3.0...v1.3.1) (2021-06-28)


### Documentation

* clean setup ([#272](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/issues/272)) ([08d393b](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/commit/08d393bde323fd793e7c325f6f2c8dbeb1dc546a))
* Update docs with examples ([#261](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/issues/261)) ([fd90096](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/commit/fd900965a6e4fbe2f10863e154cfdd2c7d47a142))

## [1.3.0](https://www.github.com/GoogleCloudPlatform/professional-services-data-validator/compare/v1.2.0...v1.3.0) (2021-06-28)


Expand Down
4 changes: 2 additions & 2 deletions ci/cloudbuild_pypi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ steps:
- 'TWINE_PASSWORD=${_TWINE_PASSWORD}'
- 'TWINE_REPOSITORY_URL=${_TWINE_REPOSITORY_URL}'
substitutions:
_TWINE_USERNAME: username
_TWINE_PASSWORD: password
_TWINE_USERNAME: __token__
_TWINE_PASSWORD:
_TWINE_REPOSITORY_URL: https://upload.pypi.org/legacy/
options:
substitution_option: 'ALLOW_LOOSE'
6 changes: 6 additions & 0 deletions ci/release_pypi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.


if [ "${TWINE_PASSWORD}" == "" ]
then
TWINE_PASSWORD=$(gcloud secrets versions access latest --secret="data-validation" --project=${PROJECT_ID})
fi

python3 -m pip install --upgrade build setuptools twine wheel
python3 -m build
python3 -m twine upload dist/*
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

name = "google-pso-data-validator"
description = "A package to enable easy data validation"
version = "1.3.0"
version = "1.3.1"
release_status = "Development Status :: 3 - Alpha"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to Beta?


with open("README.md", "r") as fh:
Expand Down