Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logic to deploy dvt on Cloud Run #280

Merged
merged 11 commits into from
Jul 22, 2021
Merged

Conversation

dhercher
Copy link
Collaborator

Adding logic in samples which walk through deploying DVT on Cloud Run.

The README for the sample walks through

  • Dockerfile used in the build
  • How to build DVT on gcr with gcloud
  • Deploying a service to Cloud Run
  • An example test against the new Cloud Run service

@dhercher dhercher requested a review from nehanene15 July 18, 2021 16:47
samples/run/README.md Outdated Show resolved Hide resolved
samples/run/README.md Outdated Show resolved Hide resolved
samples/run/README.md Show resolved Hide resolved
samples/run/README.md Outdated Show resolved Hide resolved
samples/run/deploy.sh Outdated Show resolved Hide resolved
samples/run/test.py Outdated Show resolved Hide resolved
samples/run/test.py Show resolved Hide resolved
samples/run/test.py Outdated Show resolved Hide resolved
@dhercher dhercher requested a review from nehanene15 July 22, 2021 18:41
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhercher dhercher merged commit 9076286 into develop Jul 22, 2021
@dhercher dhercher deleted the feat-cloud-run-sample branch July 22, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants