feat: Refactor CLI to fit Command Pattern #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nehanene15
changed the title
renzokuken
requested changes
Sep 10, 2021
| -sc my_bq_conn -tc my_bq_conn \ | ||
| -tbls bigquery-public-data.new_york_citibike.citibike_trips,bigquery-public-data.new_york_citibike.citibike_stations \ | ||
| --sum tripduration,start_station_name --count tripduration,start_station_name \ | ||
| -rc pso-kokoro-resources.pso_data_validator.results | ||
| -bqrh pso-kokoro-resources.pso_data_validator.results |
There was a problem hiding this comment.
I've seen inconsistencies with the -bqrh flag on the develop branch. Do we have a test that this is currently functional?
There was a problem hiding this comment.
Yes, the --bqrh flag runs exactly the same as the -rc flag using the cli_tools.get_result_handler() function. We have a test for it in test_cli_tools.py. The code will first check to see if the --bqrh flag was supplied; if not, it will check if the --rc flag exists; If neither are provided it will set to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
Updates DVT to use validation type specific commands like so:
Updated documentation and examples to reflect the change. It is backwards compatible to continue support for the
data-validation runcommand.