-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue339 ldap logmech #347
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
908d1b6
fix Issue 339 add logmech option for connect
2c292f3
feat:add logmech flag to tereadata connection
05705cf
update change for issue 339
c9f2db0
update connections.md
74512a5
update connection doc
11f8880
update flag and doc
9459987
update for flags and docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ def verify(expr, params=None): | |
|
||
|
||
def connect( | ||
host: str, user_name: str, password: str, port: Optional[int] = 1025 | ||
host: str, user_name: str, password: str, port: Optional[int] = 1025, logmech: Optional[str]='TD2' | ||
) -> TeradataClient: | ||
""" Create a TeradataClient for use with Ibis. | ||
Parameters | ||
|
@@ -49,11 +49,13 @@ def connect( | |
A Database username to connect with | ||
password : str | ||
Password for supplied username | ||
logmech : Optional[str] | ||
Logmech flag to select with (default. TD2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Can we update this to reflect the order of the parameters? (logmech after port) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep! |
||
port : Optional[int] | ||
The database port to connect to (default. 1025) | ||
Returns | ||
------- | ||
TeradataClient | ||
""" | ||
|
||
return TeradataClient(host, user_name, password, port) | ||
return TeradataClient(host, user_name, password, port, logmech) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work since in the connection config JSON expects an underscore. For adding a connection via CLI, we expect a hyphen and the code in cli_tools manages that. Could you revert this change?
Instead, there is a bug in the connections documentation here that uses a flag with an underscore instead of a hyphen. We need to change that to
--user-name
.