Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue348 casting #349

Merged
merged 3 commits into from
Dec 1, 2021
Merged

fix: Issue348 casting #349

merged 3 commits into from
Dec 1, 2021

Conversation

nehanene15
Copy link
Collaborator

  • Fixes casting error when applied via YAML
  • Fixes bug in code so that end_time is properly set before the validation result handler executes
  • Updates YAML file example in docs

@nehanene15 nehanene15 changed the title Issue348 casting fix: Issue348 casting Dec 1, 2021
Copy link
Collaborator

@renzokuken renzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nehanene15 nehanene15 merged commit 1560c7e into develop Dec 1, 2021
@nehanene15 nehanene15 deleted the issue348-casting branch December 1, 2021 21:35
mrriteshranjan added a commit to mrriteshranjan/professional-services-data-validator that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants