Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiple updates #359

Merged
merged 6 commits into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ updating the configuration.

### Managing Connections

The Data Validation Tool expects to recieve a source and target connection for
The Data Validation Tool expects to receive a source and target connection for
each validation which is run.

These connections can be supplied directly to the configuration, but more often
Expand Down Expand Up @@ -115,7 +115,7 @@ data-validation (--verbose or -v) validate column
[--service-account or -sa PATH_TO_SA_KEY]
Service account to use for BigQuery result handler output.
[--filters SOURCE_FILTER:TARGET_FILTER]
Colon spearated string values of source and target filters.
Colon separated string values of source and target filters.
If target filter is not provided, the source filter will run on source and target tables.
See: *Filters* section
[--config-file or -c CONFIG_FILE]
Expand Down Expand Up @@ -178,7 +178,7 @@ data-validation query

### Using Beta CLI Features

There may be ocassions we want to release a new CLI feature under a Beta flag.
There may be occasions we want to release a new CLI feature under a Beta flag.
Any features under Beta may or may not make their way to production. However, if
there is a Beta feature you wish to use than it can be accessed using the
following.
Expand Down Expand Up @@ -454,7 +454,7 @@ in the Data Validation tool, it is a simple process.

1. In data_validation/data_validation.py

- Import the extened Client for the given source (ie. from
- Import the extended Client for the given source (ie. from
ibis.sql.mysql.client import MySQLClient).
- Add the "<RefName>": Client to the global CLIENT_LOOKUP dictionary.

Expand Down
2 changes: 1 addition & 1 deletion ci/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ python3.6 -m nox --version

# When NOX_SESSION is set, it only runs the specified session
if [[ -n "${NOX_SESSION:-}" && ( "$NOX_SESSION" == "integration_postgres" || "$NOX_SESSION" == "integration_sql_server" ) ]]; then
./cloud_sql_proxy -instances=$CLOUD_SQL_CONNECTION & python3.6 -m nox --error-on-missing-interpreters -s "${NOX_SESSION:-}"
./cloud_sql_proxy -instances="$CLOUD_SQL_CONNECTION" & python3.6 -m nox --error-on-missing-interpreters -s "${NOX_SESSION:-}"
elif [[ -n "${NOX_SESSION:-}" ]]; then
python3.6 -m nox --error-on-missing-interpreters -s "${NOX_SESSION:-}"
else
Expand Down
2 changes: 1 addition & 1 deletion data_validation/cli_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ def split_table(table_ref, schema_required=True):
""" Returns schema and table name given list of input values.

table_ref (List): Table reference i.e ['my.schema.my_table']
scehma_required (boolean): Indicates whether schema is required. A source
schema_required (boolean): Indicates whether schema is required. A source
table reference requires schema. A target table reference does not.
"""
table_ref_list = list(csv.reader(table_ref, delimiter=".", quotechar='"'))[0]
Expand Down
4 changes: 2 additions & 2 deletions data_validation/jellyfish_distance.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ def extract_closest_match(search_key, target_list, score_cutoff=0):
"""Return str value from target list with highest score using Jaro
for String distance.
search_key (str): A string used to search for cloest match.
search_key (str): A string used to search for closest match.
target_list (list): A list of strings for comparison.
score_cutoff (float): A scorre cutoff (betwen 0 and 1) to be met.
score_cutoff (float): A score cutoff (betwen 0 and 1) to be met.
"""
highest_score = score_cutoff
highest_value_key = None
Expand Down
2 changes: 1 addition & 1 deletion docs/examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
This page describes some basic use cases of the tool.

**PLEASE NOTE:** In below commands, my_bq_conn refers to the connection name for your BigQuery project. We are validating BigQuery tables that are
available in BigQuery public datasets. These examples validate a table agaist itself for example purposes.
available in BigQuery public datasets. These examples validate a table against itself for example purposes.

Also, note that if no aggregation flag is provided, the tool will run a 'COUNT *' as the default aggregation.

Expand Down
2 changes: 1 addition & 1 deletion samples/run/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ gcloud run deploy --image gcr.io/${PROJECT_ID}/data-validation \

### Test Cloud Run Endpoint

You can easily run a request via Python. For a quick test, we have provided this logic in `test.py` to run a validation against a public BigQuery table. The example is similar and also shows how you can foward results to BigQuery from the Cloud Run job:
You can easily run a request via Python. For a quick test, we have provided this logic in `test.py` to run a validation against a public BigQuery table. The example is similar and also shows how you can forward results to BigQuery from the Cloud Run job:

```
# Copyright 2020 Google LLC
Expand Down