test: Support local integration tests for Teradata, Postgres and SQL Server #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Server * test: get Teradata user name from TERADATA_USER env var * test: add --no-cloud-sql flag to pytest options * test: instantiate CloudSQLResourceManager in a fixture when --no-cloud-sql is not passed * test: optionally get Postgres host from POSTGRES_HOST env var * test: optionally get SQL Server host from SQL_SERVER_HOST env var * test: optionally get SQL server user from SQL_SERVER_USER env var
|
Also, I just started working at Google a few months ago: ajwelch@. Feel free to ping me internally if there's anything I need to do for the CLA. |
|
Closed in favor of #364 which was submitted from my official Google account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, I'd like to run the integration tests before submitting a PR.
After some brief searching around, I concluded the best way to do that for TD is with the TD Vantage Express VM
which uses
dbcnotudfas its user name.Also, since Cloud SQL cannot re-use the same instance name until 1 week after deletion and the tests currently hard code the instance name, it's easier/cheaper to run the PG and MSSQL integration tests against local docker containers.
Changes made:
test: optionally get Teradata user name from
TERADATA_USERenv vartest: add
--no-cloud-sqlflag topytestoptionstest: instantiate
CloudSQLResourceManagerin a fixture when--no-cloud-sqlis not passedtest: optionally get Postgres host from
POSTGRES_HOSTenv vartest: optionally get SQL Server host from
SQL_SERVER_HOSTenv vartest: optionally get SQL server user from
SQL_SERVER_USERenv var