Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add 'primary_keys' and 'num_random_rows' fields to result handler #372

Merged
merged 6 commits into from
May 23, 2022
Merged

feat!: Add 'primary_keys' and 'num_random_rows' fields to result handler #372

merged 6 commits into from
May 23, 2022

Conversation

nehanene15
Copy link
Collaborator

@nehanene15 nehanene15 commented Feb 18, 2022 •
edited

Closes Issue #298 and Issue #310

  • Adds 'primary_keys' and 'num_random_rows' to result handler
  • Prints out summary results to text when using the BigQuery result handler

renzokuken
renzokuken approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@renzokuken renzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nehanene15
Copy link
Collaborator Author

/gcbrun

@nehanene15 nehanene15 changed the title feat: Issue298 resulthandler feat!: Issue298 resulthandler May 18, 2022
@nehanene15 nehanene15 changed the title feat!: Issue298 resulthandler feat!: Add 'primary_keys' and 'num_random_rows' fields to result handler May 18, 2022
@nehanene15 nehanene15 requested a review from dmedora May 20, 2022 18:30
@renzokuken
Copy link
Collaborator

LGTM

@nehanene15 nehanene15 merged commit b123279 into develop May 23, 2022
@nehanene15 nehanene15 deleted the issue298-resulthandler branch May 23, 2022 19:35
@release-please release-please bot mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzokuken renzokuken Awaiting requested review from renzokuken

@dmedora dmedora Awaiting requested review from dmedora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nehanene15 @renzokuken