Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert change from #345 that causes filters, threshold and labels to be ignored for column validations (#376) #379

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix: revert change from #345 that causes filters, threshold and labels to be ignored for column validations (#376) #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_validation/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def build_config_managers_from_args(args):

# Schema validation will not accept filters, labels, or threshold as flags
filter_config, labels, threshold = [], [], 0.0
if config_type != consts.COLUMN_VALIDATION:
if config_type != consts.SCHEMA_VALIDATION:
if args.filters:
filter_config = cli_tools.get_filters(args.filters)
if args.threshold:
Expand Down
2 changes: 1 addition & 1 deletion tests/system/data_sources/test_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
"--config-file",
CLI_CONFIG_FILE,
]
EXPECTED_NUM_YAML_LINES = 33 # Expected number of lines for validation config geenrated by CLI_STORE_COLUMN_ARGS
EXPECTED_NUM_YAML_LINES = 36 # Expected number of lines for validation config geenrated by CLI_STORE_COLUMN_ARGS
CLI_RUN_CONFIG_ARGS = ["run-config", "--config-file", CLI_CONFIG_FILE]
CLI_CONFIGS_RUN_ARGS = ["configs", "run", "--config-file", CLI_CONFIG_FILE]

Expand Down