-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Issue356 db2 test #383
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
442ecde
feat: add db2 connection
f5a3f58
feat: add connection
bf767a6
feat: DB2 connection fix
5e312a9
fix: do not require db2 client unless needed
ngdav 934020f
fix: Db2 count validation/agg functions, DB2Client
ngdav f20ea50
style: linting
ngdav 517b182
Fix: Multiple updates (#359)
bluPhy 73c6741
test: Support local integration tests for Teradata, Postgres and SQL …
ajwelch4 31841cc
fix: supporting non default schemas for mssql (#365)
nehanene15 ea2bb0c
feat: GCS support for validation configs (#340)
dmedora 796c618
fix: test for nan when calculating fail/success in combiner (#341) (#…
ajwelch4 35de28f
fix: ensure all statuses are success or fail, particularly after _joi…
ajwelch4 65e7188
feat: first class support for row level hashing (#345)
renzokuken 368c99b
feat: Hive partitioned tables support (#375)
nehanene15 acaa0f5
fix: use an appropriate column filter list for schema validation (#35…
ajwelch4 8d61178
fix: make status values consistent across validation types (#377) (#378)
ajwelch4 c7a22ce
fix: revert change from #345 that causes filters, threshold and label…
ajwelch4 24d87bb
feat: Hive hash function support (#392)
nehanene15 f8b72a3
Merge branch 'develop' into issue356-db2-test
ngdav 0ad01ac
Merge branch 'develop' into issue356-db2-test
dhercher c43352c
Merge branch 'develop' into issue356-db2-test
ngdav b35bd1e
docs: add Db2 link to README
ngdav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is likely to break anything it touches?
I believe you could pull the column list from arg, but failing that perhaps it makes more sense to raise an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that in other DBMS, you can bind * to a parameter marker, which isn't allowed in aggregation functions in Db2. The ibis code currently doesn't take this into account. This should only run in the case of count(), count() should have only one parameter, so this should have a limited impact. Replacing * with None instead causes the sqlalchemy layer to correctly substitute count(*) explicitly instead of trying to bind * to a parameter which doesn't work in Db2.
Pulling a column list and counting each column separately is not exactly the same as count(*) and would not be an expected outcome.