Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for custom query #390

Merged
merged 12 commits into from
Mar 23, 2022
Merged

feat: Support for custom query #390

merged 12 commits into from
Mar 23, 2022

Conversation

Robby29
Copy link
Member

@Robby29 Robby29 commented Mar 14, 2022

Custom query support for column level aggregations. Adds custom query CLI options to the existing validation options.
Closes #315

nehanene15
nehanene15 requested changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes that would be useful:

  • Add unit tests, specifically for generating the source/target aggregate query
  • Add documentation in the README for this new CLI option

Also, have we tested with user provided CTEs/nested SQL yet?

data_validation/cli_tools.py Outdated Show resolved Hide resolved
data_validation/data_validation.py Outdated Show resolved Hide resolved
data_validation/validation_builder.py Show resolved Hide resolved
@nehanene15
Copy link
Collaborator

/gcbrun

@Robby29
Copy link
Member Author

Robby29 commented Mar 21, 2022

/gcbrun

@Robby29
Copy link
Member Author

Robby29 commented Mar 21, 2022

/gcbrun

@Robby29 Robby29 merged commit 7a218d2 into GoogleCloudPlatform:develop Mar 23, 2022
@release-please release-please bot mentioned this pull request Mar 23, 2022
Merged
@nehanene15 nehanene15 mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehanene15 nehanene15 nehanene15 approved these changes

@renzokuken renzokuken Awaiting requested review from renzokuken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable direct comparison of raw SQL outputs
2 participants
@Robby29 @nehanene15