Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hash selective columns #407

Merged
merged 6 commits into from
Mar 25, 2022
Merged

feat: Hash selective columns #407

merged 6 commits into from
Mar 25, 2022

Conversation

nehanene15
Copy link
Collaborator

@nehanene15 nehanene15 commented Mar 25, 2022

Closes Issue #397

Adds support for selective columns for hashing and comparison-fields like so:
data-validation -v validate row -sc my_bq_conn -tc my_bq_conn -tbls pso-kokoro-resources.hivetest.struct -pk id --hash id,name

Specifically fixes excluding columns with unsupported pandas data types i.e structs, maps, etc

@nehanene15
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@renzokuken renzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove json files otherwise LGTM

@nehanene15 nehanene15 merged commit 88b6620 into develop Mar 25, 2022
@nehanene15 nehanene15 deleted the hash-selective-columns branch March 25, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants