-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get_schema with Postgres #411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. It would be great to add an integration test to either MySQL or PSQL to validate this PR. Also to BigQuery or a different source which should not be affected to ensure no gression
686dd27
to
2b468cf
Compare
@dhercher added tests for MySQL and PG. There are already schema validations for other sources, see professional-services-data-validator/tests/system/data_sources/test_bigquery.py Lines 252 to 257 in 783cdf8
|
/gcbrun |
don't know why the CI failed, both of tests succeeded on my local. and cannot get the error details |
|
This was an issue with a package being used in our Cloud Build tests. Please pull and merge the latest code from develop to resolve this. |
@nehanene15 updated with the latest code. please rerun the tests |
We've been cleaning some dependency issues which cropped up. I'm going to try tests but likely you will need to merge develop again |
/gcbrun |
updated |
/gcbrun |
#410