-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Adds custom query row level hash validation feature. #440
Conversation
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two architectural suggestions: Adding a custom query row/column
in the CLI, and moving custom query column logic to the CustomQueryBuilder() class.
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested re: how we store the custom_query_type property as a string instead of a list
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
Already resolved all the comments by Dylan. Using this option as a workaround to move forward
This PR adds the custom query row level hash validation feature with current support for Biqquery and Hive data sources.
Close #387