Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new DAG example to run DVT #485

Merged
merged 4 commits into from
May 24, 2022

Conversation

helensilva14
Copy link
Contributor

PR for the issue #459

@helensilva14 helensilva14 linked an issue May 23, 2022 that may be closed by this pull request
@helensilva14
Copy link
Contributor Author

/gcbrun

@helensilva14
Copy link
Contributor Author

/gcbrun

@helensilva14
Copy link
Contributor Author

/gcbrun

@helensilva14 helensilva14 marked this pull request as ready for review May 24, 2022 15:34
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes I'd recommend are file system changes:

  • We should move the __init__.py file into the samples directory; it doesn't need to be in the airflow folder
  • Same with bq_result_handler.py & bq_result_handler_grouped.py; they aren't airflow related so lets move them back under samples

docs/installation.md Outdated Show resolved Hide resolved
@helensilva14
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/installation.md Outdated Show resolved Hide resolved
@helensilva14 helensilva14 merged commit e3dd7ed into develop May 24, 2022
@helensilva14 helensilva14 deleted the issue459-update-composer-dag-example branch May 24, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Composer DAG example on DVT
2 participants