Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Schema validation to make case insensitive column name comparision #500

Merged
merged 3 commits into from
Jun 9, 2022
Merged

fix: Schema validation to make case insensitive column name comparision #500

merged 3 commits into from
Jun 9, 2022

Conversation

latika-wadhwa
Copy link
Contributor

@latika-wadhwa latika-wadhwa commented Jun 5, 2022 •
edited

Closes #385

@nehanene15
Copy link
Collaborator

/gcbrun

nehanene15
nehanene15 requested changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also document under Schema Validation that this will be a case insensitive column match.

data_validation/schema_validation.py Outdated Show resolved Hide resolved
renzokuken
renzokuken approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@renzokuken renzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@latika-wadhwa latika-wadhwa merged commit ee8c542 into develop Jun 9, 2022
@latika-wadhwa latika-wadhwa deleted the 385-insensitive-column-comparision branch June 9, 2022 17:03
@release-please release-please bot mentioned this pull request Jun 9, 2022
Merged
@nehanene15 nehanene15 mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzokuken renzokuken renzokuken approved these changes

@nehanene15 nehanene15 nehanene15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema validation generate wrong result if source column name is lower and target column name is upper
3 participants
@latika-wadhwa @nehanene15 @renzokuken