Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue-256-bug fixes to generate docker file #531

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fix: issue-256-bug fixes to generate docker file #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,15 @@ docs/_build
bigquery/docs/generated

# Virtual environment
.env
.venv
env/
venv/
rel_venv/
ENV/
env.bak/
venv.bak/

coverage.xml

# System test environment variables.
Expand Down
6 changes: 3 additions & 3 deletions samples/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM python:3.7.0-slim
FROM python:3.9.0-slim
ARG _APP_VERSION
COPY google_pso_data_validator-${_APP_VERSION}-py3-none-any.whl .
COPY google_pso_data_validator-${_APP_VERSION}-py2.py3-none-any.whl .
RUN apt-get update \
&& apt-get install gcc -y \
&& apt-get clean
RUN pip install --upgrade pip
RUN pip install google_pso_data_validator-${_APP_VERSION}-py3-none-any.whl
RUN pip install google_pso_data_validator-${_APP_VERSION}-py2.py3-none-any.whl
ENTRYPOINT ["python","-m","data_validation"]
4 changes: 2 additions & 2 deletions samples/docker/build_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ cd ../../
python setup.py register sdist bdist_wheel

cd samples/docker
cp ../../dist/google_pso_data_validator-${PACKAGE_VERSION}-py3-none-any.whl .
cp ../../dist/google_pso_data_validator-${PACKAGE_VERSION}-py2.py3-none-any.whl .
docker build -t data_validation:$PACKAGE_VERSION --build-arg _APP_VERSION=$PACKAGE_VERSION .
rm google_pso_data_validator-${PACKAGE_VERSION}-py3-none-any.whl
rm google_pso_data_validator-${PACKAGE_VERSION}-py2.py3-none-any.whl