feat: Remove dependency on tables list for custom query #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sramsrinivasan
force-pushed
the
issue-496
branch
from
5ed9581
to
11df129
Compare
sramsrinivasan
force-pushed
the
issue-496
branch
from
11df129
to
b05179f
Compare
|
/gcbrun |
|
This fix is a not a complete solution to the issues we have with custom query. For all custom-query row validations and custom-query column validations with aggregates (count, sum, max, min etc...), we still need -tbls argument. We will work on a change of design around custom-query next. This fix is intended to avoid any blockers associated with custom-query column validations via source_query.sql and target_query.sql files without having the need to specify -tbls arguement. |
nehanene15
changed the title
nehanene15
reviewed
Jul 14, 2022
nehanene15
approved these changes
Jul 14, 2022
nehanene15
changed the title
Yashfork
pushed a commit
to Yashfork/professional-services-data-validator
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496