-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding scaffold for concatenate as a cli operation #566
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
@@ -131,11 +131,23 @@ def get_calculated_config(args, config_manager): | |||
col_list = None if args.hash == "*" else cli_tools.get_arg_list(args.hash) | |||
fields = config_manager._build_dependent_aliases("hash", col_list) | |||
aliases = [field["name"] for field in fields] | |||
|
|||
# config_manager.append_dependent_aliases(aliases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove comment
Co-authored-by: Neha Nene <[email protected]>
…atform/professional-services-data-validator into concat_support_calc_fields
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only thing that may be good to add is some documentation on the difference between concat and hash (and how only one of the flags should be provided). I'm worried users may try to use both flags at once unaware that the --hash includes a concat.
/gcbrun |
No description provided.