Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random rows with filter option #582

Merged
merged 6 commits into from
Sep 13, 2022
Merged

fix: random rows with filter option #582

merged 6 commits into from
Sep 13, 2022

Conversation

kanhaPrayas
Copy link
Contributor

@kanhaPrayas kanhaPrayas commented Sep 8, 2022 •
edited by nehanene15

Closes #552

@kanhaPrayas kanhaPrayas changed the title fix: random rows with filter option [IN PROGRESS] fix: random rows with filter option Sep 8, 2022
@nehanene15
Copy link
Collaborator

/gcbrun

@nehanene15
Copy link
Collaborator

Just tested locally - LGTM!

@kanhaPrayas kanhaPrayas changed the title [IN PROGRESS] fix: random rows with filter option fix: random rows with filter option Sep 9, 2022
@nehanene15
Copy link
Collaborator

@kanhaPrayas The lint is failing; You'll need to run black and flake8 before merging

@kanhaPrayas kanhaPrayas merged commit da4faaf into develop Sep 13, 2022
@kanhaPrayas kanhaPrayas deleted the issue_552 branch September 13, 2022 18:22
@release-please release-please bot mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhercher dhercher dhercher approved these changes

@nehanene15 nehanene15 Awaiting requested review from nehanene15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kanhaPrayas @nehanene15 @dhercher