Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Oracle row level validation support #583

Merged
merged 6 commits into from
Sep 8, 2022
Merged

feat: Oracle row level validation support #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82092f4
fix: support NUMBER with no precision/scale
nehanene15 Aug 30, 2022
36733e5
feat: oracle support for sanitization functions
nehanene15 Sep 1, 2022
1796517
adding hash support
nehanene15 Sep 6, 2022
d13a53e
upgrades and hash funcion for oracle12+
nehanene15 Sep 7, 2022
c11c61f
Merge remote-tracking branch 'origin/develop' into issue556-oracle-row
nehanene15 Sep 7, 2022
026c9f8
Merge remote-tracking branch 'origin/develop' into issue556-oracle-row
nehanene15 Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions third_party/ibis/ibis_addon/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,12 @@ def sa_format_hashbytes(translator, expr):
hash_to_string = sa.func.convert(sa.sql.literal_column('CHAR(64)'), hash_func, sa.sql.literal_column('2'))
return sa.func.lower(hash_to_string)

def sa_format_hashbytes_oracle(translator, expr):
arg, how = expr.op().args
compiled_arg = translator.translate(arg)
hash_func = sa.func.standard_hash(compiled_arg, sa.sql.literal_column("'SHA256'"))
return sa.func.lower(hash_func)


_pandas_client._inferable_pandas_dtypes["floating"] = _pandas_client.dt.float64
IntegerColumn.bit_xor = ibis.expr.api._agg_function("bit_xor", BitXor, True)
Expand All @@ -194,5 +200,6 @@ def sa_format_hashbytes(translator, expr):
ImpalaExprTranslator._registry[RawSQL] = format_raw_sql
ImpalaExprTranslator._registry[HashBytes] = format_hashbytes_hive
OracleExprTranslator._registry[RawSQL] = sa_format_raw_sql
OracleExprTranslator._registry[HashBytes] = sa_format_hashbytes_oracle
TeradataExprTranslator._registry[RawSQL] = format_raw_sql
TeradataExprTranslator._registry[HashBytes] = format_hashbytes_teradata
2 changes: 1 addition & 1 deletion third_party/ibis/ibis_oracle/alchemy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
dt11.LONGRAW: sa.Binary,
}
_ibis_type_to_sqla.update(s_al._ibis_type_to_sqla)

_ibis_type_to_sqla[dt.String] = sa.sql.sqltypes.String(length=4000)

def _to_sqla_type(itype, type_map=None):
if type_map is None:
Expand Down
3 changes: 2 additions & 1 deletion third_party/ibis/ibis_oracle/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,8 @@ def _mod(t, expr):

def _string_join(t, expr):
sep, elements = expr.op().args
return sa.func.concat_ws(t.translate(sep), *map(t.translate, elements))
columns = [col.name for col in map(t.translate, elements)]
return sa.sql.literal_column(" || ".join(columns))


def _literal(t, expr):
Expand Down