Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibis Addons to third party #61

Merged
merged 3 commits into from
Jul 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ If you want to add an Ibis Data Source which exists, but was not yet supported i
- Import the extened Client for the given source (ie. from ibis.sql.mysql.client import MySQLClient).
- Add the "<RefName>": Client to the global CLIENT_LOOKUP dictionary.

2. In ibis_addon/operations.py
2. In third_partty/ibis/ibis_addon/operations.py
- Add the RawSQL operator to the data source registry (for custom filter support).

3. You are done, you can reference the data source via the config.
Expand Down
2 changes: 1 addition & 1 deletion data_validation/query_builder/query_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

import ibis
from ibis_addon import operations
from third_party.ibis.ibis_addon import operations


class AggregateField(object):
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"data_validation",
"data_validation.query_builder",
"data_validation.result_handlers",
"ibis_addon",
]
packages += [
"third_party.ibis.{}".format(path)
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_ibis_operations.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import pytest
import ibis.pandas

from ibis_addon import operations
from third_party.ibis.ibis_addon import operations


TABLE_DF = pandas.DataFrame([{"column": "value"}])
Expand All @@ -26,7 +26,7 @@

@pytest.fixture
def module_under_test():
from ibis_addon import operations
from third_party.ibis.ibis_addon import operations

return operations

Expand Down
File renamed without changes.
File renamed without changes.