Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQL Server custom query support #640

Merged
merged 4 commits into from
Dec 6, 2022
Merged

feat: SQL Server custom query support #640

merged 4 commits into from
Dec 6, 2022

Conversation

nehanene15
Copy link
Collaborator

Closes #638

  • Includes custom query in the QueryBuilder table projection() instead of mutate() so only the necessary columns are brought down to machine
  • Adds ibis_addon/base_sqlalchemy to overwrite any alchemy classes/methods. In this case, added conditional for isinstance(ref_op, ops.SQLQueryResult) for custom query sql() results.

@nehanene15 nehanene15 changed the title SQL Server custom query support feat: SQL Server custom query support Dec 5, 2022
@nehanene15
Copy link
Collaborator Author

/gcbrun

@nehanene15
Copy link
Collaborator Author

/gcbrun

@nehanene15
Copy link
Collaborator Author

/gcbrun

@nehanene15 nehanene15 merged commit 98ab010 into develop Dec 6, 2022
@nehanene15 nehanene15 deleted the issue638-mssql-custom branch December 6, 2022 17:09
@release-please release-please bot mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raniksingh Raniksingh Raniksingh approved these changes

@renzokuken renzokuken Awaiting requested review from renzokuken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom query for SQL Server
2 participants
@nehanene15 @Raniksingh