Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logic to add allow-list to support datatype matching with a provided list in case of mismatched datatypes between source and target #643

Merged
merged 7 commits into from
Jan 16, 2023

Conversation

kanhaPrayas
Copy link
Contributor

@kanhaPrayas kanhaPrayas commented Dec 7, 2022

This PR is under progress. This has been raised for parallel review. So that useful review comments can be added as part of development.

Closes #606

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 7, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides two small comments.

data_validation/cli_tools.py Outdated Show resolved Hide resolved
data_validation/schema_validation.py Outdated Show resolved Hide resolved
…ided list in case of mismatched datatypes between source and target
@kanhaPrayas kanhaPrayas changed the title [In Progress] Code commit with initial logic. feat: Logic to add allow-list to support datatype matching with a provided list in case of mismatched datatypes between source and target Jan 12, 2023
@kanhaPrayas
Copy link
Contributor Author

/gcbrun

Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides some minor doc changes!

data_validation/cli_tools.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
data_validation/schema_validation.py Outdated Show resolved Hide resolved
Prayas Purusottam added 3 commits January 13, 2023 17:07
…ided list in case of mismatched datatypes between source and target
…ided list in case of mismatched datatypes between source and target
…ided list in case of mismatched datatypes between source and target
@kanhaPrayas
Copy link
Contributor Author

/gcbrun

@kanhaPrayas kanhaPrayas merged commit 269f8dc into develop Jan 16, 2023
@kanhaPrayas kanhaPrayas deleted the issue_606 branch January 16, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable an 'allowlist' for data type mappings for schema validations
2 participants