feat: Support config directory for running validations and add multithreading for DB queries #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmedora
commented
Dec 22, 2022
•
dmedora
commented
- Adds support for specifying a directory to run validation yamls from (either local or GCS).
- Adds multithreading to source & target database query requests, so these happen simultaneously, effectively halving total time waiting for external query execution.
…e build_config_managers_from_yaml; functions for --config-file as before, --config-dir in progress.
|
/gcbrun |
nehanene15
approved these changes
Dec 27, 2022
|
|
||
| def build_config_managers_from_yaml(args, config_file_path): | ||
| """Returns List[ConfigManager] instances ready to be executed.""" | ||
| if "config_dir" in args and args.config_dir: |
There was a problem hiding this comment.
Why do we need the first conditional? Can't we just do if args.config_dir
There was a problem hiding this comment.
It's because of the (still supported) run-config legacy option - I've only added the config-dir subparser to the newer configs run, so when run-config is used, the config-dir variable is not initialized to null and so it errors.
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.