Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gcp secret manger support for DVT #704

Merged
merged 19 commits into from
Feb 27, 2023
Merged

feat: gcp secret manger support for DVT #704

merged 19 commits into from
Feb 27, 2023

Conversation

mokhahmed
Copy link
Contributor

/gcbrun

nehanene15
nehanene15 reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Could we also add a unit test for the SecretManagerBuilder?

data_validation/cli_tools.py Outdated Show resolved Hide resolved
data_validation/secret_manger.py Outdated Show resolved Hide resolved
data_validation/secret_manger.py Outdated Show resolved Hide resolved
data_validation/secret_manger.py Outdated Show resolved Hide resolved
docs/connections.md Outdated Show resolved Hide resolved
@mokhahmed
code review fixes
1a33b28 
- fix manger typo to manager
- rename argument description
- add google-cloud-secret-manager to requirement file
@mokhahmed
code review fixes
176a9ac 
- revert the naming of variables connections.md
@mokhahmed
code review fixes
9430f63 
- revert the naming of variables connections.md
@mokhahmed
code review fixes
fe30a18 
- revert the naming of variables connections.md
@mokhahmed
code review fixes
4737aec 
- revert the naming of variables connections.md
@mokhahmed
Merge branch 'develop' into secret-manager
0a06cde 
# Conflicts:
#	setup.py
nehanene15
nehanene15 reviewed Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good; we should add unit tests for the secret manager class.

@mokhahmed
code review fixes
4b6aca7 
- add test cases for secret manager class
@mokhahmed
code review fixes
a48d2a1 
- revert the naming of variables connections.md
@mokhahmed
code review fixes
362b8c2 
- move secret manager testcases
@mokhahmed
code review fixes
4f857c7 
- revert the naming of variables connections.md
@Raniksingh Raniksingh merged commit d6c40f1 into develop Feb 27, 2023
@Raniksingh Raniksingh deleted the secret-manager branch February 27, 2023 11:05
@release-please release-please bot mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nj1973 nj1973 nj1973 left review comments

@nehanene15 nehanene15 nehanene15 left review comments

@Raniksingh Raniksingh Raniksingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mokhahmed @nj1973 @nehanene15 @Raniksingh