Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cater for query driven comparisons in date format override code #733

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

nj1973
Copy link
Contributor

@nj1973 nj1973 commented Feb 17, 2023

This change fixes a bug introduced by issue 680 which introduced non-engine specific date formats when comparing date/timestamp columns.

@nj1973 nj1973 linked an issue Feb 17, 2023 that may be closed by this pull request
@nj1973
Copy link
Contributor Author

nj1973 commented Feb 17, 2023

/gcbrun

@nj1973 nj1973 requested a review from mohdt786 February 17, 2023 11:41
Copy link
Contributor

@mohdt786 mohdt786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

validate custom-query row commands are working with the changes
Thank you!

@nj1973 nj1973 merged commit 0a22643 into develop Feb 17, 2023
@nj1973 nj1973 deleted the fix/issue-732-bug-in-issue-680-changes branch February 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate custom-query row: Exception since issue 680 changes introduced
2 participants