Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: score-cutoff changed to 1 #779

Merged
merged 3 commits into from
Mar 31, 2023
Merged

docs: score-cutoff changed to 1 #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1b6707
score-cutoff changed
rishabkhawad Mar 21, 2023
f7f601b
docs: score-cutoff changed
rishabkhawad Mar 21, 2023
9514894
Merge branch 'issue-678' of https://github.com/GoogleCloudPlatform/pr…
rishabkhawad Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,13 +456,12 @@ target. The find-tables tool:
- Finally, it prints a JSON list of tables which can be a reference for the
validation run config.

Note that our score cutoff default is a 0.8, which was manually tested to be an
accurate value. If no matches occur, reduce this value.
Note that our score cutoff default is 1. If no matches occur, reduce this value as deemed necessary.

```
data-validation find-tables --source-conn source --target-conn target \
--allowed-schemas pso_data_validator \
--score-cutoff 0.8
--score-cutoff 1
```

### Using Beta CLI Features
Expand Down
2 changes: 1 addition & 1 deletion data_validation/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def get_table_map(client, allowed_schemas=None):

def find_tables_using_string_matching(args):
"""Return JSON String with matched tables for use in validations."""
score_cutoff = args.score_cutoff or 0.8
score_cutoff = args.score_cutoff or 1

mgr = state_manager.StateManager()
source_client = clients.get_data_client(mgr.get_connection_config(args.source_conn))
Expand Down