feat: add Impala connection optional parameters (#743) #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
nehanene15
reviewed
Apr 3, 2023
| ): | ||
| auth_mechanism = (auth_mechanism, "PLAIN")[auth_mechanism is None] | ||
| database = (database, "default")[database is None] | ||
| port = (port, 10000)[port is None] | ||
| kerberos_service_name = (kerberos_service_name, "impala")[ | ||
| kerberos_service_name is None | ||
| ] | ||
| use_ssl = (use_ssl, False)[use_ssl is None] | ||
| timeout = (timeout, 45)[timeout is None] | ||
| pool_size = (pool_size, 8)[pool_size is None] |
There was a problem hiding this comment.
Do we need to add user, password, ca_cert, and the other variables here too? Or will it be picked up from the default parameters?
There was a problem hiding this comment.
I took as a reference how the code was already handling "host" parameters. Since the default value is None then it is not added in this section; for the other variables the default values are boolean or Int, and that is why it validates if the value is None to assign the default value. If it requires a change just let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #743
Add optional parameters supported by Impala Connector, to give support in DVT:
Parameters added:
Attaching result for execution of the help command for the connection:
