Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add db2 hash and concat support #800

Merged
merged 5 commits into from
Apr 14, 2023
Merged

feat: add db2 hash and concat support #800

merged 5 commits into from
Apr 14, 2023

Conversation

ngdav
Copy link
Collaborator

@ngdav ngdav commented Apr 11, 2023

Add db2 row hash support and db2 row concat support.
Fix issue where primary keys are being translated to CLOB which is not supported. PKs (and all other ibis.String types) now translate to VARCHAR(3000).

@ngdav
Copy link
Collaborator Author

ngdav commented Apr 11, 2023

/gcbrun

@ngdav ngdav marked this pull request as ready for review April 11, 2023 03:24
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nehanene15
Copy link
Collaborator

We could also add random row support (or leave that for another PR) Looks like DB2 supports RAND() so it should just be one line add here

@ngdav ngdav merged commit c16e2f7 into develop Apr 14, 2023
@ngdav ngdav deleted the issue799-db2-clob branch April 14, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect query generation for cast integer to string for DB2 row validation.
3 participants