Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dry-run bug when running configs, added CODEOWNERS, and docs #865

Merged
merged 1 commit into from
May 19, 2023

Conversation

nehanene15
Copy link
Collaborator

Closes #863 by adding --dry-run to the configs parser
Closes #811 by adding codeowners file
Closes #21 by adding documentation on how to use Secret Manager for connections

@nehanene15 nehanene15 requested a review from dmedora May 18, 2023 21:34
@nehanene15
Copy link
Collaborator Author

/gcbrun

Copy link
Member

@dmedora dmedora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nehanene15 nehanene15 merged commit 1779772 into develop May 19, 2023
@nehanene15 nehanene15 deleted the issue863-dry-run-bug branch May 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants