Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing operations for SQL Server - ExtractEpochSeconds, ExtractDayOfYear, ExtractWeekOfYear #870

Merged

Conversation

helensilva14
Copy link
Contributor

Closes #869

/gcbrun

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@helensilva14 helensilva14 added the automerge Summon MOG for automerging label May 23, 2023
third_party/ibis/ibis_mssql/compiler.py Outdated Show resolved Hide resolved
third_party/ibis/ibis_mssql/compiler.py Outdated Show resolved Hide resolved
@helensilva14 helensilva14 changed the title fix: Add ExtractEpochSeconds operation for SQL Server and other date/time ones fix: Add missing operations for SQL Server: ExtractEpochSeconds, ExtractDayOfYear, ExtractWeekOfYear May 24, 2023
@helensilva14 helensilva14 changed the title fix: Add missing operations for SQL Server: ExtractEpochSeconds, ExtractDayOfYear, ExtractWeekOfYear fix: Add missing operations for SQL Server - ExtractEpochSeconds, ExtractDayOfYear, ExtractWeekOfYear May 24, 2023
Copy link
Collaborator

@nehanene15 nehanene15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helensilva14 helensilva14 merged commit 709dd4c into develop May 25, 2023
@helensilva14 helensilva14 deleted the issue869-ibis-exception-operation-not-defined-error branch May 25, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Summon MOG for automerging
Projects
None yet
2 participants