Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Adding UTF encoding for Oracle hash generation #878

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix: Adding UTF encoding for Oracle hash generation #878

merged 1 commit into from
Jun 9, 2023

Conversation

piyushsarraf
Copy link
Contributor

@piyushsarraf piyushsarraf requested a review from a team as a code owner June 8, 2023 06:33
@piyushsarraf
Copy link
Contributor Author

/gcbrun

svetakvsundhar
svetakvsundhar reviewed Jun 8, 2023
View reviewed changes
Copy link

@svetakvsundhar svetakvsundhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any tests to ensure that functionality remains the same?

ngdav
ngdav approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@ngdav ngdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyushsarraf
Copy link
Contributor Author

@svetakvsundhar No, I don't think so.

@piyushsarraf piyushsarraf merged commit 2e24eae into develop Jun 9, 2023
3 checks passed
@piyushsarraf piyushsarraf deleted the issue875-OracleUTF branch June 9, 2023 04:43
@release-please release-please bot mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetakvsundhar svetakvsundhar svetakvsundhar left review comments

@ngdav ngdav ngdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piyushsarraf @svetakvsundhar @ngdav