-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Ibis Upgrade to 5.1.0 #894
Conversation
…ird party in favor of Ibis snowflake connector
…s to postgres cast
…transport from merge
…ata-validation -v configs run -c config.yaml for upgrade, clean up comments
…on on timestamp columns
…thod in SelectBuilder
/gcbrun |
…upport, support binary_float datatype for Oracle custom query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome job.
@piyushsarraf , I also saw the "2 packages found for backend 'bigquery'" message. It was because my virtual environment was not clean. I fixed it by removing the venv, creating it fresh and then |
@piyushsarraf |
@nehanene15 I just verified the below version which works for Redshift. |
Hey Neha, Thanks. Sundar Mudupalli |
Closes #317 (Ibis upgrade)
Closes #839 (BQ BIGNUMERIC is now expressed as decimal(76, 38))
Closes #767 (Spanner timestamp exception)
Closes #833 (MSSQL support for sum on datetime columns)
Closes #832 (MSSQL support for aggregating varchar/char columns)
Closes #719 (MSSQL/BQ column validation support for float data types)
Closes #821 (DB2 custom query index out of range bug fix)
Closes #814 (Python 3.11 support)
Breaking Change: Python 3.7 is not supported anymore. This PR also updates most of the required Python packages.
Summary: Updates Ibis to the newest 5.1.0 release. It touches a lot of files, but mainly the backend third_party connection implementations.
Notes:
[(“name”, “Neha”)]
and now it will be[[“name”, “Neha”]]
(This doesn’t affect BQ schema or outputs to the BQ result table)third_party/ibis/ibis_mysql
User-focused changes:
string[non-nullable]
. Post upgrade it will be expressed as!string