Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Teradata NUMBER with no precision/scale support #914

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: Teradata NUMBER with no precision/scale support #914

merged 1 commit into from
Jul 26, 2023

Conversation

nehanene15
Copy link
Collaborator

Closes #913

  • Catches the case where precision/scale = -128 in the HELP COLUMN output, which happens when the column type is 'NUMBER' with no precision/scale in TD.
  • Fixes small doc bug after Ibis upgrade

@nehanene15 nehanene15 requested a review from a team as a code owner July 25, 2023 19:01
@nehanene15 nehanene15 changed the title fix: Teradata NUMBER with no precision/scale fix: Teradata NUMBER with no precision/scale support Jul 25, 2023
@nehanene15
Copy link
Collaborator Author

/gcbrun

@sundar-mudupalli-work
Copy link
Contributor

Neha,

Great work and fast!. Thank you. Could you add a test to core_types for this data type. It will catch issues with this type in the future.

I don't know if it makes sense to add this for other databases - we can think about that. Postgres for instance ignores
the SQL standard when a precision is not specified.

Thanks

Sundar Mudupalli

@sundar-mudupalli-work sundar-mudupalli-work mentioned this pull request Jul 26, 2023
Open
@sundar-mudupalli-work sundar-mudupalli-work enabled auto-merge (squash) July 26, 2023 19:31
sundar-mudupalli-work
sundar-mudupalli-work approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@sundar-mudupalli-work sundar-mudupalli-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you

@sundar-mudupalli-work sundar-mudupalli-work merged commit f9db68f into develop Jul 26, 2023
3 checks passed
@sundar-mudupalli-work sundar-mudupalli-work deleted the issue913-td-number branch July 26, 2023 20:40
@release-please release-please bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundar-mudupalli-work sundar-mudupalli-work sundar-mudupalli-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teradata validations: Error when validating NUMBER or DECIMAL with no precision/scale
2 participants
@nehanene15 @sundar-mudupalli-work