Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generate-table-partitions): Works on all 7 platforms - BigQuery, Hive, MySQL, Oracle, Postgres, SQL Server and Teradata. #922

Merged
merged 9 commits into from
Aug 1, 2023
Merged

feat(generate-table-partitions): Works on all 7 platforms - BigQuery, Hive, MySQL, Oracle, Postgres, SQL Server and Teradata. #922

merged 9 commits into from
Aug 1, 2023

Conversation

sundar-mudupalli-work
Copy link
Contributor

@sundar-mudupalli-work sundar-mudupalli-work commented Jul 27, 2023 •
edited

This pull request has two major changes

  1. Updated the generate-table-partitions logic to use Row_number() so that it works on Teradata
  2. Update test for Postgres so that the test now passes (generated filters changed slightly)
  3. Add new tests for BigQuery, Hive, MySQL, Oracle, SQL Server and Teradata.

Cheers.

Sundar Mudupalli

@sundar-mudupalli-work
Changes to test suites to test generate-partitions.
2092b4f 
Teradata does not work.
@sundar-mudupalli-work
Updated generate-partitions to use simpler rownumber method which als…
ab50e21 
…o works on teradata.

Tested with postgres and updated postgres tests. Other test will likely need to be modified.
Requires the ibis upgrade, hence merging with develop before finishing testing.
@sundar-mudupalli-work
Fixing some changes that were due to the use of git stash.
e082061
@sundar-mudupalli-work
Merge branch 'develop' into test-generate-partitions
7ab5ef9
@sundar-mudupalli-work
Update to test suites to add test for generate partitions
fb18ab2
@sundar-mudupalli-work
Merge branch 'develop' into test-generate-partitions
545fea8 
Adding tests for generate-table-partitions
@sundar-mudupalli-work sundar-mudupalli-work requested a review from a team as a code owner July 27, 2023 21:58
@sundar-mudupalli-work
Copy link
Contributor Author

/gcbrun

@sundar-mudupalli-work sundar-mudupalli-work changed the title Test generate partitions feat(generate-table-partitions): Works on all 7 platforms - BigQuery, Hive, MySQL, Oracle, Postgres, SQL Server and Teradata. Jul 27, 2023
@sundar-mudupalli-work
Copy link
Contributor Author

/gcbrun

1 similar comment
@sundar-mudupalli-work
Copy link
Contributor Author

/gcbrun

@sundar-mudupalli-work
Copy link
Contributor Author

/gcbrun

@nj1973
Copy link
Contributor

nj1973 commented Aug 1, 2023

/gcbrun

Raniksingh
Raniksingh approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Raniksingh Raniksingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundar-mudupalli-work sundar-mudupalli-work merged commit aa84d7a into develop Aug 1, 2023
3 checks passed
@sundar-mudupalli-work sundar-mudupalli-work deleted the test-generate-partitions branch August 1, 2023 17:16
@release-please release-please bot mentioned this pull request Aug 1, 2023
Merged
@helensilva14 helensilva14 mentioned this pull request Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raniksingh Raniksingh Raniksingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sundar-mudupalli-work @nj1973 @Raniksingh